Add storage pool blueprints and integration tests for VM, GKE, and Slurm - #6150
Add storage pool blueprints and integration tests for VM, GKE, and Slurm#6150rahimkhan19 wants to merge 40 commits into
Conversation
…isk precondition validation
…gin, and node modules
…-balanced/throughput types
…ersistent_disks variable configuration
…o google provider
…ions, and clean up GKE/VM storage test build definitions
rahimkhan19
added
the
release-key-new-features
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the GCP storage configuration by introducing standardized blueprints and automated integration tests for Hyperdisk storage pools across VM, GKE, and Slurm environments. These changes ensure that persistent disks are correctly provisioned and bound to the intended storage pools, improving infrastructure reliability and verification within the CI/CD pipeline. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces storage pool configurations (balanced and throughput) across GKE, Slurm, and VM example blueprints, along with corresponding integration tests and validation playbooks. A high-severity issue was identified in the Slurm storage validation playbook (test-slurm-storage.yml), where the controller's additional disk name is incorrectly hardcoded as slurm_controller-data instead of being dynamically prefixed with the cluster name, which will cause the integration test to fail.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for Hyperdisk storage pools across GKE, Slurm, and VM examples, including new validation tests and Cloud Build configurations to verify correct disk placement. The review feedback recommends updating the examples/README.md index to document the new storage-vm.yaml blueprint and the renamed storage-slurm.yaml blueprint, in accordance with the repository style guide. Additionally, it is suggested to remove a redundant 15-second pause in the GKE storage pool validation test to optimize test execution time.
…cumentation and testing configurations
3 participants
This PR introduces blueprints and integration tests for GCP Storage Pools across : VM, GKE, and Slurm.
Key Changes:
storage-vm.yamlblueprint with a complete Cloud Build pipeline.test-vm-storage.yml) to verify persistent disks are securely placed in target Hyperdisk storage pools.storage-gke.yamlblueprint and CI pipeline to strictly assert Hyperdisk storage pool placement through dynamically provisioned PVs.rapid-storage-slurm.yamltostorage-slurm.yaml.slurm-nodeset, login, and controller instance templates are bound to the correct pools.